gem / oq-engine

OpenQuake Engine: a software for Seismic Hazard and Risk Analysis
https://github.com/gem/oq-engine/#openquake-engine
GNU Affero General Public License v3.0
378 stars 273 forks source link

BooreEtAl2014 is broken #6975

Closed cbworden closed 3 years ago

cbworden commented 3 years ago

When requesting const.StdDev.INTER_EVENT the module now returns a scalar rather than the expected array.

In https://github.com/gem/oq-engine/blob/master/openquake/hazardlib/gsim/boore_2014.py line 258 is:

stddevs.append(tau)

it should be something like:

stddevs.append(np.full_like(dists.rjb, tau))

The other two types of stddev are okay.

micheles commented 3 years ago

Looks like a leftover from the recent huge refactoring of hazardlib. See https://groups.google.com/g/openquake-users/c/Tj5t1rJ7MX0/m/BHLrOPt6AQAJ for the reasons behind the change.