Closed CatalinaYepes closed 1 year ago
The error message indicated in number 1 is a bug. Even after providing vs30 values for observation the same error message appears.
Debugging, I found out that the error is only triggered when running scenario damage or risk calculations. The same input files can be used for estimating gmfs without having the error.
During the association of the list of assets by site to the site collection (done with function assoc2
), some stations are currently filtered out.
We need to consider for the association the locations from the asset + the ones in the station_data_file
(within the maximum_distance
).
This is not a wrong error message. The problem is much more serious: the site collection does not contain the stations. So we fneed to extend the site collection with the station sites (see https://github.com/gem/oq-engine/pull/8949). I also believe the maximum_distance
is a red herring, i.e. it is okay as it is.
Two error messages to improve:
1. Missing vs30 values at the location of the observations
When missing vs30 values at the location of the observations, the following error message appears (see also the question in forum) :
Possible error message:
2. Input files with different columns
We need to raise an error when files don't have the same fields. In my case, the following error appears when indicating in the job file the following site model:
site_model_file = Site_model.csv site_model_stations.csv
The field
custom_site_id
was present only in thesite_model_stations.csv
file. This error should also be raised for other type of files, like exposure modes.