search

gem / oq-engine

OpenQuake Engine: a software for Seismic Hazard and Risk Analysis
https://github.com/gem/oq-engine/#openquake-engine
GNU Affero General Public License v3.0
377 stars 273 forks source link

BCHydroESHM20 Logic Tree Issue #9486

Closed elifyild closed 6 months ago

elifyild commented 6 months ago

In BCHydroESHM20SInter and BCHydroESHM20SSlab gmm logic trees, the variable theta_6_adjustment is not correctly referenced as it appears in the code. Thus, it is not working and it should affects the median value derived from gmm branch. It is written in the code as theta6_adjustment. Related codes are in below:

Logic tree: https://github.com/gem/oq-engine/blob/d197c4170d753f9cd22a1e9d5013e8d20bccfbbd/openquake/qa_tests_data/mosaic/EUR/in/gmmLT.xml#L844

Abrahamson 2015 code: https://github.com/gem/oq-engine/blob/d197c4170d753f9cd22a1e9d5013e8d20bccfbbd/openquake/hazardlib/gsim/abrahamson_2015.py#L290

micheles commented 6 months ago

~It is easier to change the code than the model, so I would do that~ With the hazard team we decided to fix the gsim logic tree file.

micheles commented 6 months ago

Closing because it is an issue on the gsim logic tree file and not on the engine side. We will make a new release of the EUR model soon.