search

gem / oq-platform

DEPRECATED. Please refer to https://github.com/gem/oq-platform2
8 stars 3 forks source link

IRV - Remove color themes #564

Closed ptormene closed 8 years ago

ptormene commented 8 years ago

I believe color themes are not actually useful in this application, because:

  1. We display one single layer at a time, so we don't need to differentiate styles of different layers
  2. Below the layer, we always have OpenStreetMap (and the user can't change it), so we just need to use colors that look fine with it.

Furthermore, the theme management contained a bug, that caused the application to become slower and slower every time a different color theme was selected. Instead of attempting to fix the bug, I am rather proposing to remove the unused feature (resolves https://github.com/gem/oq-platform/issues/504)

ptormene commented 8 years ago

Chris already gave his approval to this change

nastasi-oq commented 8 years ago

LGTM