gembaadvantage / uplift

Semantic versioning the easy way. Powered by Conventional Commits. Built for use with CI.
https://upliftci.dev
MIT License
57 stars 7 forks source link

[Bug]: Action not triggering another workflow / ignoring GITHUB_TOKEN override #400

Closed Bastianowicz closed 4 months ago

Bastianowicz commented 5 months ago

What happened?

In my project I have to separate workflows.

One is for "release" which is the uplift action triggering uplift release. This action I configured to use a personal access token instead of the GITHUB_TOKEN (like said in the docs). ❌ This does not seem to work though. The tags created are still authored by uplift bot.

The other is to publish the new version to npm. This does work when I manually push a tag. But it does not automatically after the release pipeline ran since the tags are still being created by the uplift bot.

Further the PAT in the settings says "never used". I regenerated it and added it freshly as an action secret. It does not seem to be applied to the action since it says "never used" nevertheless.

Steps to reproduce it

1. Create a workflow "X" that runs on any created tag.
2. Override your Github_token like in the [docs](https://upliftci.dev/ci/github/#triggering-another-workflow)
3. Commit a fix or feat commit and thus run the uplift action

## expected behaviour
* X runs after the uplift action ran
* the tag is authored by you (your PAT)

## experienced
* the tag is still authored by Uplift Bot
* of course the workflow X does not run

Your uplift configuration

# Github Action Config
  release:
    name: Release
    if: github.ref == 'refs/heads/main' && !startsWith( github.event.commits[0].message, 'build(deps-dev)') && !startsWith( github.event.commits[0].message, 'ci(uplift)')
    runs-on: ubuntu-latest
    needs: test
    steps:
      - uses: actions/checkout@v4
        with:
          fetch-depth: 0
      - name: Release
        if: github.ref == 'refs/heads/main'
        uses: gembaadvantage/uplift-action@v2.0.1
        with:
          args: release
        env:
          GITHUB_TOKEN: ${{ secrets.GH_TOKEN_UPLIFT }}

Which version?

v2.0.1

Which operating system(s) are you using?

Linux

Optional debug output

No response

Code of Conduct

Bastianowicz commented 5 months ago

I already posted this here but with no success. Maybe some can help

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Bastianowicz commented 5 months ago

Bump

ga-paul-t commented 5 months ago

@Bastianowicz, apologies for not seeing the issue raised regarding the uplift-action project. It must have disappeared into my spam. The uplift-action documentation is not in sync with the uplift project. I have updated the documentation to include instructions on:

I will update the uplift documentation to reflect these changes also

Bastianowicz commented 4 months ago

Thank you. The additonal with: token: ${{}} in the checkout step actually did the trick. Would have tried that for ages. Thank you!