search

gembaadvantage / uplift

Semantic versioning the easy way. Powered by Conventional Commits. Built for use with CI.
https://upliftci.dev
MIT License
57 stars 7 forks source link

feat: support trimming any text lines preceding the line containing the conventional commit type #416

Closed albertocsm closed 4 months ago

albertocsm commented 4 months ago

impl proposal for #415

ga-paul-t commented 4 months ago

@albertocsm I'll take a look at this asap. Really appreciate the contribution and it looks like a useful addition

ga-paul-t commented 4 months ago

@albertocsm, can you please rebase your branch? Thanks.

albertocsm commented 4 months ago

@albertocsm, can you please rebase your branch? Thanks.

done. also, ive noticed my commit is not signed. ill take care of that as well.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 62.85714% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (3b85254) to head (177bd0f). Report is 29 commits behind head on main.

Files Patch % Lines
internal/semver/parser.go 72.22% 2 Missing and 3 partials :warning:
internal/task/changelog/changelog.go 50.00% 3 Missing and 1 partial :warning:
cmd/uplift/changelog.go 50.00% 1 Missing and 1 partial :warning:
cmd/uplift/release.go 50.00% 1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #416 +/- ## ========================================== + Coverage 80.07% 81.80% +1.73% ========================================== Files 40 42 +2 Lines 1977 1638 -339 ========================================== - Hits 1583 1340 -243 + Misses 292 192 -100 - Partials 102 106 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.