gemfarmer / jekyll-liquify

A Jekyll filter that parses Liquid from front matter
https://rubygems.org/gems/jekyll-liquify
Other
38 stars 3 forks source link

Issue with LiquidFilter #8

Open couet opened 11 months ago

couet commented 11 months ago

Since a few days I get this error message when running the command bundle exec jekyll serve --baseurl="/base" :

bundler: failed to load command: jekyll (/usr/local/lib/ruby/gems/3.1.0/bin/jekyll)
/usr/local/lib/ruby/gems/3.1.0/gems/jekyll-liquify-0.0.3/lib/jekyll-liquify.rb:15:in `<top (required)>': uninitialized constant LiquidFilter (NameError)

Liquid::Template.register_filter(LiquidFilter)
                                 ^^^^^^^^^^^^

and the web site stops building.

Do you know what it could be ?

couet commented 11 months ago

We forced a lower version in order to resurrect our website: https://github.com/root-project/web/pull/932 Is there a big in 0.0.3 ?

jonsage commented 11 months ago

I'm having this same issue

glenrobson commented 11 months ago

We also had the same issue:

/home/runner/work/website/website/vendor/bundle/ruby/3.1.0/gems/jekyll-liquify-0.0.3/lib/jekyll-liquify.rb:15:in `<top (required)>': uninitialized constant LiquidFilter (NameError)

Liquid::Template.register_filter(LiquidFilter)
                                 ^^^^^^^^^^^^
    from /home/runner/work/website/website/vendor/bundle/ruby/3.1.0/gems/jekyll-4.1.1/lib/jekyll/external.rb:60:in `require'

in build and had to downgrade to 0.0.2.

couet commented 11 months ago

@gemfarmer : Is there a fix foreseen?

yasulab commented 10 months ago

I have investigated this issue and found that this commit changed Liquid Filter plugin's name from:

- LiquidFilter
+ LiquifyFilter

But lib/jekyll-liquify.rb still refers to outdated LiquidFilter module. https://github.com/gemfarmer/jekyll-liquify/blob/9ab75afb83c2bc954eb790e7ea16e1e57d867dde/lib/jekyll-liquify.rb#L15

So updating the module name above would fix this issue.

UPDATE: Sent a pull request for this https://github.com/gemfarmer/jekyll-liquify/pull/9