search

gemidyne / microtf2

A custom gamemode for Team Fortress 2 - Players compete against each other to get the most points by playing a series of rapid fire microgames in order to win the round!
https://www.gemidyne.com/projects/microtf2
GNU General Public License v2.0
32 stars 17 forks source link

Add natives for other plugins to consume #95

Closed safalin1 closed 5 years ago

safalin1 commented 5 years ago

This will allow for tighter integrations with other server plugins.

Some natives that should be added are for things like:

FortyTwoFortyTwo commented 5 years ago

Another native i'd like to suggest is to get current and max round gamemode is currently at, and allow to change/increase max round during mid-game.

Server we use have a custom mapvote, not using umc-core or mapchooser so we'd need to know when is a good moment to start a mapvote.

safalin1 commented 5 years ago

Makes sense - I have been wanting to make separate "stock" plugins for things like the intermission. Having fwds/natives for it would make it better because then the main plugin can handoff to a subplugin to handle the voting process and then let the main plugin know when to resume gameplay

safalin1 commented 5 years ago

Tested as working - but not added all forwards yet. Core player forwards implemented so far.

Need to add:

safalin1 commented 5 years ago

I've tested this - it seems to be working fine. However my test plugin wasn't properly ending the mapvote which made me worry a little that it working before was a fluke. It was returning true for "HasMapVoteEnded" but for some reason it kept waiting and didn't advance

I need to do more testing on that part of this ticket - however the other forwards appear to working correctly.

safalin1 commented 5 years ago

Tested further, everything is working fine. There was a logic bug due to the slightly different nature of the method compared to what it was before.