search

gemini-hlsw / gem

prototype postgres back-end for ocs
Other
15 stars 5 forks source link

Rename long slits #229

Closed jdnavarro closed 6 years ago

jdnavarro commented 6 years ago

This naming scheme gets closer to their actual width.

See the original comment thread bringing the naming issue up.

I left F2 untouched since the current name sounds like it's close enough to what we want.

      id       |   short_name    | slit_width |  decker   |      long_name       | obsolete
---------------+-----------------+------------+-----------+----------------------+----------
 Pinhole       | Pinhole         |          0 | Imaging   | 2-Pixel Pinhole Grid | f
 SubPixPinhole | Sub-Pix Pinhole |          0 | Imaging   | Sub-Pixel Pinhole Gr | f
 LongSlit1     | Long Slit 1px   |          1 | Long Slit | 1-Pixel Long Slit    | f
 LongSlit2     | Long Slit 2px   |          2 | Long Slit | 2-Pixel Long Slit    | f
 LongSlit3     | Long Slit 3px   |          3 | Long Slit | 3-Pixel Long Slit    | f
 LongSlit4     | Long Slit 4px   |          4 | Long Slit | 4-Pixel Long Slit    | f
 LongSlit6     | Long Slit 6px   |          6 | Long Slit | 6-Pixel Long Slit    | f
 LongSlit8     | Long Slit 8px   |          8 | Long Slit | 8-Pixel Long Slit    | f
tpolecat commented 6 years ago

Looks good. Do you need to regen the enums and commit those too?

jdnavarro commented 6 years ago

Do you need to regen the enums and commit those too?

🤦‍♂️ I forgot. I also have to the renames throughout the code.