search

gemini-hlsw / gem

prototype postgres back-end for ocs
Other
15 stars 5 forks source link

gem.math optics #259

Closed tpolecat closed 6 years ago

tpolecat commented 6 years ago

I needed a break from type experiments so I filled out Lensand Iso for stuff in gem.math. I'm using GenLens instead of @Lenses because I don't like having to suppress the bogus warning and I want a doc comment with @group Optics so the lenses are grouped in the Scaladoc.

This adds optics and tests but doesn't change any existing code.

sraaphorst commented 6 years ago

I haven't had the pleasure of using Monocle yet, but I am learning a lot through these PRs.

tpolecat commented 6 years ago

ok fixed that doc bug and rebased. this is ready for another 👍

tpolecat commented 6 years ago

Works for me!