ProgramId.fromString - Githubissues

gemini-hlsw / gem

prototype postgres back-end for ocs

Other

15 stars 5 forks source link

Closed tpolecat closed 6 years ago

tpolecat commented 6 years ago

This fuses the parse/format pairs for program ids.

Strings containing whitespace are not valid program ids. All other strings are. This means we have at best a Prism.
Leading zeroes on science program indices are allowed (and discarded) which weakens the relationship to Format. If we drop this behavior we go back up to Prism.

tpolecat commented 6 years ago

Format because multiple strings will map to the same ID (because of the leading zeros), correct?

Yes, correct. But we could close that loophole. It seems like more of a parser oversight than an intentional design.

swalker2m commented 6 years ago

But we could close that loophole. It seems like more of a parser oversight than an intentional design.

Agree, we should probably just disallow leading zeros and upgrade to Prism.

tpolecat commented 6 years ago

Ok I'll make that change.