gemini-hlsw / gem

prototype postgres back-end for ocs
Other
15 stars 5 forks source link

remove indexed types #283

Closed tpolecat closed 6 years ago

tpolecat commented 6 years ago

This is big PR, sorry, but relatively straightforward.

This removes indexed types (and indeed all parameterization in the main model) in favor of simpler (but more verbose) ADTs with cases per instrument.

The data layer is largely the same, with a few exceptions:

Some misc. cleanup is technically unrelated but aided in the refactoring.

Open questions, to be addressed later:

Followup tasks:

tpolecat commented 6 years ago

We should probably squash-merge this because nothing prior to the last commit will pass CI.

tpolecat commented 6 years ago

Let me know if any of my responses alarmed you. If not I'll merge.

swalker2m commented 6 years ago

Let me know if any of my responses alarmed you. If not I'll merge.

No alarms and no surprises. Merge away. 👍