search

gemini-hlsw / lucuma-odb

5 stars 0 forks source link

Add ability to save guide target, change guideEnvironment #1379

Closed toddburnside closed 2 months ago

toddburnside commented 2 months ago

This adds a guideEnvironment on the in the targetEnvironment of the observation. Instead of returning the ordered list of potential guide stars (as guideEnvironments does) only a single guide star, or an error, will be returned. If a guide star name has been set, that guide star will be returned. If not set, or the observation has changed since the name was set, gaia will be queried and the "best" available guide star will be returned. There is a lookupIfUndefined parameter on guideEnvironment that explore can set to false, such that a null can be returned when the guide star is not set. And, if only the name is requested in the query gaia will not be called unless the name is not set (or is invalid) AND lookupIfUndefined is true.

I left the old guideEnvironments query to make it easier for navigate to convert. Once navigate is on the new guideEnvironment, guideEnvironments will be removed.

swalker2m commented 2 months ago

I left the old guideEnvironments query to make it easier for navigate to convert. Once navigate is on the new guideEnvironment, guideEnvironments will be removed.

Does Explore call GAIA directly in order to provide the < and > buttons for cycling through options?

cquiroz commented 2 months ago

I left the old guideEnvironments query to make it easier for navigate to convert. Once navigate is on the new guideEnvironment, guideEnvironments will be removed.

Does Explore call GAIA directly in order to provide the < and > buttons for cycling through options?

Yes, it does the guidestar calculation on the browser