gemini-hlsw / lucuma-odb

5 stars 0 forks source link

Add GMOS read mode and gain to calibration configuration #1458

Closed swalker2m closed 1 month ago

swalker2m commented 1 month ago

Calibration observations are required for distinct instrument configurations, but not all parameters matter for this purpose. For example, two identical GMOS long slit observations with distinct ROIs do not require distinct calibrations. On the other hand, if the observations use different gratings then calibrations for each are required.

This PR adds the GMOS read mode and amp gain to the subset used to distinguish calibration instrument configurations. It refactors the logic a bit as well to confine the configuration subset differences in one place.