search

gemini-hlsw / lucuma-sso

Lucuma Single Sign-On Service and Libraries
6 stars 3 forks source link

createApiKeys by role type #624

Closed cquiroz closed 1 year ago

cquiroz commented 1 year ago

Right now the createApiKeys creates a key taking as a parameter a role-id as:

  createApiKey(role: RoleId!): String!

Would it make sense to instead of the role type instead as

   createApiKey(roleType: RoleType!): String!

If not we need an end point to get the RoleId for each role type

tpolecat commented 1 year ago

To summarize a conversation in Slack, you do need the actual role ID here. The user almost certainly doesn't have a role of every type, and may have more than one of the same type in the case of NGO users.

cquiroz commented 1 year ago

Thanks for the clarification