gemini-hlsw / lucuma-sso

Lucuma Single Sign-On Service and Libraries
6 stars 3 forks source link

Grackle 0.16 #749

Closed tpolecat closed 1 year ago

tpolecat commented 1 year ago

This updates Grackle and Skunk and so forth.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (1a5d8c6) 56.87% compared to head (e2dc363) 54.52%. Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #749 +/- ## ========================================== - Coverage 56.87% 54.52% -2.36% ========================================== Files 42 42 Lines 1236 1194 -42 Branches 8 10 +2 ========================================== - Hits 703 651 -52 - Misses 533 543 +10 ``` | [Files](https://app.codecov.io/gh/gemini-hlsw/lucuma-sso/pull/749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gemini-hlsw) | Coverage Δ | | |---|---|---| | [modules/service/src/main/scala/Main.scala](https://app.codecov.io/gh/gemini-hlsw/lucuma-sso/pull/749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gemini-hlsw#diff-bW9kdWxlcy9zZXJ2aWNlL3NyYy9tYWluL3NjYWxhL01haW4uc2NhbGE=) | `4.76% <ø> (ø)` | | | [...dules/service/src/main/scala/database/Codecs.scala](https://app.codecov.io/gh/gemini-hlsw/lucuma-sso/pull/749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gemini-hlsw#diff-bW9kdWxlcy9zZXJ2aWNlL3NyYy9tYWluL3NjYWxhL2RhdGFiYXNlL0NvZGVjcy5zY2FsYQ==) | `95.23% <ø> (ø)` | | | [...service/src/main/scala/graphql/GraphqlRoutes.scala](https://app.codecov.io/gh/gemini-hlsw/lucuma-sso/pull/749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gemini-hlsw#diff-bW9kdWxlcy9zZXJ2aWNlL3NyYy9tYWluL3NjYWxhL2dyYXBocWwvR3JhcGhxbFJvdXRlcy5zY2FsYQ==) | `88.88% <100.00%> (ø)` | | | [...les/service/src/main/scala/graphql/SsoTables.scala](https://app.codecov.io/gh/gemini-hlsw/lucuma-sso/pull/749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gemini-hlsw#diff-bW9kdWxlcy9zZXJ2aWNlL3NyYy9tYWluL3NjYWxhL2dyYXBocWwvU3NvVGFibGVzLnNjYWxh) | `100.00% <ø> (ø)` | | | [...es/service/src/main/scala/graphql/SsoMapping.scala](https://app.codecov.io/gh/gemini-hlsw/lucuma-sso/pull/749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gemini-hlsw#diff-bW9kdWxlcy9zZXJ2aWNlL3NyYy9tYWluL3NjYWxhL2dyYXBocWwvU3NvTWFwcGluZy5zY2FsYQ==) | `81.11% <50.00%> (+0.26%)` | :arrow_up: | | [...les/service/src/main/scala/database/Database.scala](https://app.codecov.io/gh/gemini-hlsw/lucuma-sso/pull/749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gemini-hlsw#diff-bW9kdWxlcy9zZXJ2aWNlL3NyYy9tYWluL3NjYWxhL2RhdGFiYXNlL0RhdGFiYXNlLnNjYWxh) | `67.44% <28.84%> (-6.22%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/gemini-hlsw/lucuma-sso/pull/749/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gemini-hlsw)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tpolecat commented 1 year ago

Didn't we have to do something special when we updated the ODB to a newer Postgres?

There's a manual process but the SSO databases are already up to date, it was just the compose file that was lagging.