search

gemini-testing / gemini-gui

GUI for gemini
MIT License
69 stars 18 forks source link

Add filtering on suites #72

Closed SpaceK33z closed 5 years ago

SpaceK33z commented 7 years ago

This PR adds the ability to filter on a suite by adding ?suite=MySuite to the URL.

It is only possible to do it by modifying the URL at the moment, but I could also add the ability to do this in the UI if you want.

The use-case for this is that it allows you to use the GUI in other environments.

I'm not entirely happy about the code, so please nitpick if you don't like it ;).

SpaceK33z commented 7 years ago

I realize now that I forgot to make tests. If you agree with the idea of this PR I'll add tests!

sipayRT commented 7 years ago

hi. I'm not sure that understood your idea correctly. Are you need to run some specific test by adding suite name to url? why not --grep suiteName?

SpaceK33z commented 7 years ago

The idea is that you can leave gemini-gui running, and use the webapp in other webapps.

E.g. with React Storybook, you can add a tab on each component page that only shows the relevant tests for that component. This is for my specific use-case, but I can imagine there are a lot more. Having to close the CLI and then re-open it with a new "grep" can be a huge hassle.

SpaceK33z commented 7 years ago

Do you think this is a valid use-case? I really think it's too much hassle to find the terminal and restart the whole server for every time you want to scope the tests.