Current solution for restoring orientation may fail – namely, when test times out. Setting orientation before the test run seems more reliable.
Frankly, we should also remove restoring orientation in postActions when the related option is configured, but that can lead to some unfortunate consequences – as all projects can't be updated simultaneously – device may occur in unexpected state. Before doing so, runner should be updated and default orientation should be set in all projects. Just making these changes major do not make the transition easier.
Point for discussion – should gemini throw when trying to set default orientation for browser which has no such capability.
Current solution for restoring orientation may fail – namely, when test times out. Setting orientation before the test run seems more reliable.
Frankly, we should also remove restoring orientation in
postActionswhen the related option is configured, but that can lead to some unfortunate consequences – as all projects can't be updated simultaneously – device may occur in unexpected state. Before doing so, runner should be updated and default orientation should be set in all projects. Just making these changes major do not make the transition easier.Point for discussion – should
geminithrow when trying to set default orientation for browser which has no such capability.