gemini-testing / gemini

💀💀💀[DEPRECATED] Use hermione
https://github.com/gemini-testing/hermione
MIT License
1.5k stars 149 forks source link

Add "java" as explicit dependency #942

Closed Pomax closed 5 years ago

Pomax commented 5 years ago

Not everyone has java installed (for reasons ranging from literally never needing it, to not wanting the security holes it opens up, to some other reason), so mentioning that there is a hard dependency on java in the README.md and installation instructions on the github.io page is an excellent idea.

sipayRT commented 5 years ago

hi

java is selenium-standalone deps, not gemini. You can use SauceLabs or BrowserStack without java

will add it in docs, tnx

Pomax commented 5 years ago

I know, but it's still a dependency worth pointing out because a lot of people expect instructions like these to cover everything they need to do in order to go from "I have nothing installed" to "I have a working copy of [thing]".

Thanks for adding it to the docs!