search

gemini-testing / looks-same

Node.js library for comparing images
MIT License
660 stars 55 forks source link

TypeScript support #40

Closed MattIzSpooky closed 5 years ago

MattIzSpooky commented 6 years ago

This library looks great! Do you have any plans on adding TypeScript support so us TypeScripters can join in on the fun without having to write the types ourselves?

sipayRT commented 6 years ago

hi

we don't have any plans on it but you can send PR ;)

xcatliu commented 5 years ago

@sipayRT I've sent a pr in #42

xcatliu commented 5 years ago

Sent a pr to https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30336

DudaGod commented 5 years ago

@xcatliu hello. Thanks for your efforts, I will definitely look at your PR this week.

MattIzSpooky commented 5 years ago

Closed due to acceptance of pull request #42.

A big thank you from the Netherlands, @xcatliu!