search

gemini-testing / png-img

Lite libpng wrapper for node.js
MIT License
29 stars 13 forks source link

Build fails for node >= 10 due to outdated nan #43

Closed bbraun92 closed 5 years ago

bbraun92 commented 5 years ago

In file included from ../src/init.cc:1: In file included from ../../nan/nan.h:192: ../../nan/nan_maybe_43_inl.h:112:15: error: no member named 'ForceSet' in 'v8::Object' return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs); ~~~ ^

Hey,

when trying to build png-img 2.2.0 using node >= 10 , the build fails due to the error above. Maybe someone could update to a more recent version of nan, since 2.7.0 is heavily outdated? 2.10.0 seems to work fine.

EDIT: Nevermind, was a problem with my package-lock.json.

Best regards