search

gemini-testing / png-img

Lite libpng wrapper for node.js
MIT License
29 stars 13 forks source link

Add arm files from libpng #62

Closed sanyabas closed 2 years ago

sanyabas commented 2 years ago

On master npm run test will fail on M1 Macs with following error:

dyld: lazy symbol binding failed: Symbol not found: _png_init_filter_functions_neon
  Referenced from: ~/projects/png-img/build/Release/png_img.node
  Expected in: flat namespace

dyld: Symbol not found: _png_init_filter_functions_neon
  Referenced from: ~/projects/png-img/build/Release/png_img.node
  Expected in: flat namespace

./dev/test: line 15: 63349 Abort trap: 6           ${ROOT}/node_modules/.bin/mocha

All tests pass after adding ARM files. Should fix https://github.com/gemini-testing/hermione/issues/605 Similar issue was fixed in another package using libpng: https://github.com/miscellanea/dlib/commit/8efe5b94f5c7dffa2bb14e7a1b4d1f6499e754c8