search

gemini-testing / testplane

Testplane (ex-hermione) browser test runner based on mocha and wdio
https://testplane.io
MIT License
678 stars 62 forks source link

fix: correctly screen element after moveTo #928

Closed DudaGod closed 2 months ago

DudaGod commented 2 months ago

fix - https://github.com/gemini-testing/testplane/issues/779

DudaGod commented 2 months ago

Is round safe to use here in terms of flakiness? Would floor be better or not?

It is safe because under the hood Math.floor is used for top and left coords and Math.ceil for right and bottom. Here - https://github.com/gemini-testing/testplane/blob/master/src/browser/client-scripts/rect.js#L80-L87