gemini-testing / testplane

Testplane (ex-hermione) browser test runner based on mocha and wdio
https://testplane.io
MIT License
687 stars 62 forks source link

Make better-sqlite3 installation work out of the box #981

Open shadowusr opened 1 month ago

shadowusr commented 1 month ago

Verify latest release

Hermione version

No response

Last Hermione version that worked

No response

Which area(s) of Hermione are affected? (leave empty if unsure)

Hermione core

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

When using yarn+pnp (but I suspect it will be the same with npm as well!), when installing testplane you get an error:

STDERR gyp ERR! stack TypeError: Cannot assign to read only property 'cflags' of object '#<Object>'

Additional info:

node -v v20.11.1
node-gyp -v v7.1.2

The issue here is probably old version of node-gyp, but ideally it should work always regardless of this. Also, we need to make sure that it works in offline environment (without access to github or external internet)

Actual Behavior

Failed to build better-sqlite3 with node-gyp 7, yarn+pnp

Expected Behavior

Testplane installation works out of the box

Which Node.js version are you using?

20.11.1