gemini-testing / testplane

Testplane (ex-hermione) browser test runner based on mocha and wdio
https://testplane.io
MIT License
687 stars 62 forks source link

fix: revert round of viewport #997

Closed DudaGod closed 1 month ago

DudaGod commented 1 month ago

What is done

Revert change from - https://github.com/gemini-testing/testplane/pull/928. The problem is that after this change, an error occurs under certain conditions: Image to composite must have same dimensions or smaller. I solved this error in this PR - https://github.com/gemini-testing/testplane/pull/992, but I can't merge it, because it leads to differences in screenshots (when viewport has fractional dimensions).

Because of this, I am rolling back the old change and we will implement it back in the next major - testplane@9.