search

geminiplanetimager / gpi_pipeline

Gemini Planet Imager Data Reduction Pipeline
Other
8 stars 6 forks source link

Updated grid ratio #108

Closed rjderosa closed 5 years ago

rjderosa commented 5 years ago

Modified the apodizer specification file with updated grid ratios and new second-order ratios. Pipeline should now read the SATSORDR keyword to determine which were used.

mperrin commented 5 years ago

Thanks @rjderosa!

mperrin commented 5 years ago

The PR looks good. But since you're updating the satellite spot grid ratios, should we add some brief citation/source information on where those new values come from? Could be just some additional comments in that file. Would be good to have that source information recorded for reference.

rjderosa commented 5 years ago

We can add a URL to the gemini website once I send them the report and they upload it.

mperrin commented 5 years ago

Any idea when that will be? Do you want me to go ahead and merge this now (in which case we have to remember to come back later and add the URL), or leave this PR open and pending until they tell you the URL? Either way's fine with me

rjderosa commented 5 years ago

Hopefully soon, just waiting to hear back from Vanessa. Let's wait until we can add the URL.

semaphoreP commented 5 years ago

If it is longer than 1-2 weeks, let's merge this branch and make a new issue to add the reference when it appears. Just so that these changes get propagated.

rjderosa commented 5 years ago

Hopefully should get a link to the gemini instrument page in a couple of days that we can add to finalise this.

rjderosa commented 5 years ago

Which has now been added. The branch can now be merged. Should we release this as 1.4.1?

mperrin commented 5 years ago

Let's have a discussion about release at an upcoming data telecon?

semaphoreP commented 5 years ago

@mperrin should we merge this into master? I think we should do that irrespective of a release, but I also think a release is a good idea.

rjderosa commented 5 years ago

Shall we merge this?