geminiplanetimager / gpi_pipeline

Gemini Planet Imager Data Reduction Pipeline
Other
8 stars 6 forks source link

Distinguish between primitive argument "Type" keyword and Calibration File Type. #28

Open dsavransky opened 8 years ago

dsavransky commented 8 years ago

See discussion in the comment thread for #375.

Initial implementation of a primitive attribute CalFileType as distinct from Type committed in 2303. Right now this is just used by the Recipe Editor to set the filename wildcard to e.g. dark.fits when browsing for files in the calibration directory. CalFileType attribute has only been defined for a subset of primitives in the headers.

Next steps 1) define calfiletype for the rest of the primitives that have CalibrationFile arguments. 2) update __start_primitive so it checks the CalFileType argument attribute instead of relying on hard-coded calfiletype variables at the start of all the primitives.

Caution - right now it's reading the CalFileType attributes directly from the gpi_pipeline_primitives.xml index of all the primitives. So if you try to change the CalFileType for a primitive in one given XML file I don't think that will work. But I can't think of any circumstances in which one would want to do that, so this is probably OK.