Open dsavransky opened 8 years ago
Recovering rm journals for issue:
mperrin: This seems like more trouble than it would be worth at this point. Would have to re-reduce al the calibration files if we were to start cleaning up this legacy infrastructure code, even though I do still think it's a bit of a mess.
Right now we have several different indicators of what type of file a given pipeline (particularly an output reduced calibration file) is:
1) the file suffix ( "_wavecal", "_distor") 2) the FILETYPE keyword ("Wavelength Solution Cal File", "Distortion Calibration") 3) the calibration file type label used by the CalDB ("wavecal", "distor") 4) the CalFileType label, which used to be the 'Type' argument to each primitive prior to my work on #376. ("wavecal", "distorcal")
These are right now defined in various places all over the place and it's not very organized. The same text has to be entered in multiple places which can be error prone. There are cases like distortion where the CalFileType label doesn't match the suffix.
Here's my suggestion to clean things up: