search

geminiplanetimager / gpi_pipeline

Gemini Planet Imager Data Reduction Pipeline
Other
8 stars 6 forks source link

Update doc comments for wavecal wrapper #77

Closed dsavransky closed 8 years ago

dsavransky commented 8 years ago

Reminder note for Marshall to update the comments about how the backgrounds are handled in microlens fitting wavecal extraction, since this Schuyler pointed out this is non obvious. As discussed during hack day.

mperrin commented 8 years ago

Legacy Rejected/wontfix issue migrated from redmine issue tracker. Originally filed by @mperrin on 2014-04-17

@swolff9 do you remember any of these details? We can just close this issue now, right?

dsavransky commented 8 years ago

Recovering rm journals for issue:

mperrin: Huh. I have no recollection at this point what this was about. Schuyler, do you remember what it was we wanted to document 6 months ago?

swolff: Hmm. I do not remember this. I checked and none of my notes from the Hack day mention this either. This may have been before we did a bunch of work on the documentation. I can't think of why we thought it was important to document a specific behavior of the wavecal wrapper as this is not a primitive and is hidden from most users.

mperrin: Any objection to marking this one as 'Rejected' since we can't remember what we were thinking in Chicago and it doesn't appear to be high priority?

swolff: Fine by me.