gemire / daofusion

Automatically exported from code.google.com/p/daofusion
0 stars 1 forks source link

Problem with findSubCriteria in com.anasoft.os.daofusion.criteria.NestedPropertyCriteria - incorrect result criteria hierarchy #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
If I have create nested property criteria with duplication in association 
path elements ('metaData.value' and 'status.value'), result criteria 
hierarchy is not correct.
SubCriteria for status.value is bound (parent) to metaData SubCriteria, 
but must be bound to status SubCriteria.

Problem is on line 
com.anasoft.os.daofusion.criteria.NestedPropertyCriteria#198, where 
comparation of names is insufficient. There must be comparation of quite 
association path - from root to element.

Source code version: trunk/2009-04-15-16:46

Original issue reported on code.google.com by janci.pa...@gmail.com on 15 Apr 2009 at 2:46

GoogleCodeExporter commented 9 years ago
http://codereview.appspot.com/41085/show

Original comment by janci.pa...@gmail.com on 16 Apr 2009 at 9:11

GoogleCodeExporter commented 9 years ago
Looks good, I will add a test case for it as well so we are sure we handle 
duplicate
association paths within DAO Fusion properly.

Original comment by Vojtech....@gmail.com on 16 Apr 2009 at 2:02

GoogleCodeExporter commented 9 years ago
Patch for this issue is available for review at 
http://codereview.appspot.com/40111.

Original comment by Vojtech....@gmail.com on 16 Apr 2009 at 3:44

GoogleCodeExporter commented 9 years ago

Original comment by Vojtech....@gmail.com on 17 Apr 2009 at 11:34