search

gemnasium / logrus-graylog-hook

Graylog hook for logrus
MIT License
87 stars 63 forks source link

case-insensitive import collision Sirupsen #23

Closed yuancheng-p closed 7 years ago

yuancheng-p commented 7 years ago

Hi, when using the gralog-hook, the package could not compile with the following message: 

case-insensitive import collision: "vendor/github.com/Sirupsen/logrus" and "vendor/github.com/sirupsen/logrus"

The https://github.com/sirupsen/logrus has changed the from "Sirupsen" to "sirupsen". More details here:

Note that I've vendored the latest logrus and I had to modify the logrus-gralog-hook's import locally. Maybe logrus-gralog-hook should update the import statements with lower case "sirupsen"?

yuancheng-p commented 7 years ago

@gravis thanks for fixing. When do you plan to update the dependency in gopkg.in/gemnasium/logrus-graylog-hook.v2 ?

gravis commented 7 years ago

Oops, I forgot the branches... right away :)

gravis commented 7 years ago

Done!

bkleef commented 7 years ago

@gravis thanks a lot for fixing this for @yuancheng-p but this change broke all our 100+ repos. I suggest to use a capital S as all examples use a capital S: https://github.com/sirupsen/logrus#example and only change it to lowercase when https://github.com/sirupsen/logrus/pull/526 is accepted.

gravis commented 7 years ago

@bkleef really for that, it wasn't intended of course. Regarding sirupsen/logrus#526, if it's not merged today, I'll revert my change, and wait for the merge. Sounds good to you?

gravis commented 7 years ago

@bkleef you're right, the change WAS reverted, I went a little too fast here. As I appear to be the only active maintainer of this repo, I will remove today's commits and tags completely, to avoid confusion (and let me find the time to solve this issue with my head focused...)

gravis commented 7 years ago

Reverted, sorry for this mess, I went way too fast into this issue.

bkleef commented 7 years ago

@gravis thanks a lot for your very fast action and reply! Sounds great, thanks a lot!

yuancheng-p commented 7 years ago

Hi @bkleef and @gravis , I feel so sorry for bothering. I agree to stick to the upper-case "S".

Actually I used glide for vendoring but since the repository url revert to lower-case now, it can not find resolve the package.

$ glide get github.com/Sirupsen/logrus
...
[ERROR] Update failed for github.com/Sirupsen/logrus: The Remote does not match the VCS endpoint
[ERROR] Failed to checkout packages: The Remote does not match the VCS endpoint

Here I got a work around solution to solve this : https://github.com/sirupsen/logrus/pull/384#issuecomment-264035988