search

gemnasium / logrus-graylog-hook

Graylog hook for logrus
MIT License
87 stars 63 forks source link

Add option that prevents blocking in all cases #28

Closed ivajloip closed 6 years ago

ivajloip commented 6 years ago

As indicated in this video from dotgo conference, sometimes we don't ever want to block due to logging issues. With this change the user can specify this.

gravis commented 6 years ago

Thanks for your pull request. Nevertheless, Graylog messages are sent through UDP, so it's never blocking. The async portion of code in this lib is to avoid blocking calling code for message creation and sending. That's why it might be confusing. Anyway, there's no need for this change, so I'm closing this.

ivajloip commented 6 years ago

You are right! Thanks for the nice library :smile: