Fix #33: Low performance due to GC on gzip/zlib writers

gemnasium / logrus-graylog-hook

Graylog hook for logrus

MIT License

87 stars 63 forks source link

Fix #33: Low performance due to GC on gzip/zlib writers #35

Closed jorygeerts closed 5 years ago

jorygeerts commented 5 years ago

Fix for #33

jorygeerts commented 5 years ago

Note: the failed build for Go 1.6 and lower is due to a change in x/sys/unix, see https://github.com/golang/go/issues/26576 for details. I don't think this is something I broke nor something I can fix.

gravis commented 5 years ago

This API is just awful. Having the writer exported, as well as most of the fields lead us to a lot of conditions and edge cases in the code. We should rewrite this in the future and bump a major version to break the API. Anyway, this is the best we can achieve on that foundation. Thanks for your contribution.