gempir / go-twitch-irc

go irc client for twitch.tv
MIT License
358 stars 59 forks source link

Ratelimiter doesn't count multiple joins per message #164

Closed gempir closed 2 years ago

gempir commented 3 years ago

You can send multiple joins per JOIN irc message.

See this function https://github.com/gempir/go-twitch-irc/blob/b173bfca87681979eca791b37aacba5f931428dd/client.go#L610

The ratelimiter doesn't take that into account.

When the client isn't connected yet, go-twitch-irc will "cache" the joins and then write one bigger join message.