Ratelimiter Interface and mutex

gempir / go-twitch-irc

go irc client for twitch.tv

MIT License

356 stars 59 forks source link

Ratelimiter Interface and mutex #172

Closed gempir closed 2 years ago

gempir commented 2 years ago

the Ratelimiter could be called multiple times when used by multiple clients #171
Use an interface instead so anyone can provide Ratelimiter

coveralls commented 2 years ago

Coverage increased (+0.02%) to 97.966% when pulling e6c774249c1c7f0333bedb2279fe02892e7be5e7 on ratelimit into 0a43a55ac05b28abff6c3836674ad104dea63daa on master.

gempir commented 2 years ago

@TroyDota if you wanna have a look

TroyKomodo commented 2 years ago

Looks great! Exactly what I was thinking.

TroyKomodo commented 2 years ago

The only thing that is concerning is that you sleep and then unlock the mutex.

gempir commented 2 years ago

Why is that concerning? That's the correct moment to unlock the mutex, no?

gempir commented 2 years ago

I think how we do it here is perfectly fine