search

gemrb / gemrb

GemRB is a portable open-source implementation of Bioware’s Infinity Engine.
https://gemrb.org
GNU General Public License v2.0
983 stars 184 forks source link

Savegame portraits and screenshot #1807

Open burner1024 opened 1 year ago

burner1024 commented 1 year ago

Bug description

Using Gemrb save in original, portraits are larger and cropped.

Steps to reproduce

  1. Save in Gemrb.
  2. Start original BG2, go to save list.
  3. See the portraits.

Expected behavior

Normal size, non-cropped portraits.

Screenshots

Top is original save, bottom is same one resaved in GemRB. Captura desde 2023-05-26 18-11-18

GemRB version (check as many as you know apply)

Video Driver (check as many as you know apply)

burner1024 commented 1 year ago

OK, and just noticed that screenshot is also buggy. Same 2 saves in GemRB: Captura desde 2023-05-26 18-14-25

lynxlynxlynx commented 1 year ago

IIRC @bradallred ripped part of this scaling out on purpose. Maybe back in the subviews transition. Either way, we can eventually fix it back up

bradallred commented 1 year ago

the new video backends will support scaled rendering of sprites which will fix this

lynxlynxlynx commented 1 year ago

I'm pretty sure the previews in iwd should fill in the whole space as well — now we don't.