gemrb / gemrb

GemRB is a portable open-source implementation of Bioware’s Infinity Engine.
https://gemrb.org
GNU General Public License v2.0
983 stars 184 forks source link

iwd fire giants missing weapons #2117

Open lynxlynxlynx opened 2 months ago

lynxlynxlynx commented 2 months ago

Noticed in iwd2 with Lothar (0xF308) #2109, who is currently using the main iwd animation type (9 IE_ANI_TWO_FILES_3). This family is used also for 0xE** animations. His base bam is MGFI, suffixes are two chars per stance and east orientations are in separate files. That's all expected.

This one, however, and it's not clear if there are other such cases, also has a weapon overlay. MGFI has two, one with a sword (eg. MGFIsA1E)and one with a hammer (eg. MGFIwA1E). Seems like the item animation is just cut from two chars to one. But also, for this family we don't even try to create a weapon overlay from what I can tell, so that needs changing as well.

lynxlynxlynx commented 2 months ago

A simple search with iesh shows these candidates:

iwd2 (14)

> MBA1AA1E > MBA1MA1E > MBA1SA1E > > MBA2AA1E > MBA2WA1E > MBA2SA1E > > MDGU1A1E > > MWI4AA1E > MWI4MA1E > MWI4SA1E > > MSKTAA1E > MSKTSA1E > > MSKASA1E > MSKAAA1E > MSKAMA1E > > MSKL1A1E > > MDRFAA1E > MDRFMA1E > MDRFSA1E > > MDRMMA1E > MDRMSA1E > > MGFISA1E > MGFIWA1E > > MLI2AA1E > MLI2MA1E > MLI2HA1E > > MLIZQA1E > MLIZCA1E > MLIZHA1E > > MYU1AA1E > MYU1SA1E > MYU1CA1E > > MYU2AA1E > MYU2SA1E > MYU2CA1E

iwd1 (15)

> MSKL1A1E > > MSKAAA1E > MSKASA1E > MSKAMA1E > > MSKTAA1E > MSKTSA1E > > MDGU1A1E > > MLI2MA1E > MLI2AA1E > MLI2HA1E > > MLIZQA1E > MLIZHA1E > MLIZCA1E > > MGFIWA1E > MGFISA1E > > MYU2AA1E > MYU2SA1E > MYU2CA1E > > MYU1AA1E > MYU1SA1E > MYU1CA1E > > MBA1AA1E > MBA1MA1E > MBA1SA1E > > MBA2AA1E > MBA2WA1E > MBA2SA1E > > MBA3AA1E > MBA3MA1E > MBA3SA1E > > MSAHCA1E > MSAHSA1E > > MSATCA1E > MSATSA1E > > MWI4AA1E > MWI4MA1E > MWI4SA1E

So mostly the same bams.

Exclusive to iwd2: MDRF, MDRM Exclusive to iwd1: MBA3, MSAT, MSAH