search

gemrb / gemrb

GemRB is a portable open-source implementation of Bioware’s Infinity Engine.
https://gemrb.org
GNU General Public License v2.0
929 stars 178 forks source link

Are we still missing anything relevant from ToBEx #564

Open lynxlynxlynx opened 4 years ago

lynxlynxlynx commented 4 years ago

existing ToBEx stuff, but see bottom of official docs for concise bit info:

  • RECHECK:Visual Effect Video Cells (VVCs)? (any missing bits?)
  • RESEARCH: Cure: Dispellable Effects (Dispel Magic) [58], Use EFF File [177], Spell Effect: Cast Spell on Condition [232] (do we need it?)
  • ~perhaps Effect Stacking Behaviour — limiting~; not needed for regeneration/poison/disease in gemrb and conflicts with EE difficulty bit, so we'll ignore it.

docs: https://htmlpreview.github.io/?https://github.com/BGforgeNet/TobEx/blob/master/WeiDU/TobEx/TobEx_redist/readme/TobExReference.htm

lynxlynxlynx commented 4 years ago

From #426:

-ToBEx Level One Proficiency Restrictions (what's this?)

In BG1 during main character generation fighter class starts with 4 stars of proficiency points but you can only distribute maximum 2 stars per weapon. IIRC this is handled by a table, but needs checking.

This already works and the table is profsmax.2da.

burner1024 commented 4 years ago

I'm using effect stacking thing in one of my mods... Maybe allocate another bit for this?

lynxlynxlynx commented 4 years ago

It would have to be a different bit, so I'm sure it'd be very useful.

burner1024 commented 4 years ago

Did you mean to say "not sure"? It's not a problem to set another bit, and there's enough to choose from yet. Unfortunately, it was introduced for a reason, on classic engine there's nothing that could quite emulate it (and maybe EEs too, actually, not sure). Although I do understand the compatibility implications.

lynxlynxlynx commented 4 years ago

Yeah, missing "not", sorry.

burner1024 commented 3 years ago

I managed to build TobEx. Given that stacking is not a widely used feature (in fact, I don't know of anyone but me using it...), I probably could relocate the bit.

lynxlynxlynx commented 3 years ago

Asked on the forum for more examples: https://www.gibberlings3.net/forums/topic/31784-mods-using-tobex-effect-stacking/

If none crop up, it will simplify things. But I suspect it was added for SR.

burner1024 commented 3 years ago

Cool, let's see. I'm not sure it's directly related to poison/regen, though. Those are likely separate fixes.