Conserto dos testes, mais atualização do gitignore

[JoaoFelipe]

As alterações parecem ok, mas os testes falharam aqui:

Professors features
  edit page
    should be able to edit record (FAILED - 1)
Student features
  insert page
    should have city widget for birth_city (FAILED - 2)
  edit page
    should be able to edit record (FAILED - 3)

Failures:

  1) Professors features edit page should be able to edit record
     Failure/Error: expect(page).to have_css("td.name-column", text: "teste")
       expected to find css "td.name-column" but there were no matches
     # ./spec/features/professors_spec.rb:136:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:130:in `block (3 levels) in <top (required)>'
     # /home/joao/.rvm/gems/ruby-3.2.1/gems/database_cleaner-core-2.0.1/lib/database_cleaner/strategy.rb:30:in `cleaning'
     # /home/joao/.rvm/gems/ruby-3.2.1/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:34:in `block (2 levels) in cleaning'
     # /home/joao/.rvm/gems/ruby-3.2.1/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:35:in `cleaning'
     # ./spec/rails_helper.rb:129:in `block (2 levels) in <top (required)>'

  2) Student features insert page should have city widget for birth_city
     Failure/Error: expect(page.all("select#widget_record_#{state_field} option").map(&:text)).to eq ["Selecione o estado", "RJ", "SP"]

       expected: ["Selecione o estado", "RJ", "SP"]
            got: ["Selecione o estado"]

       (compared using ==)
     # ./spec/support/place_widgets_helpers.rb:24:in `expect_to_have_city_widget'
     # ./spec/features/students_spec.rb:108:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:130:in `block (3 levels) in <top (required)>'
     # /home/joao/.rvm/gems/ruby-3.2.1/gems/database_cleaner-core-2.0.1/lib/database_cleaner/strategy.rb:30:in `cleaning'
     # /home/joao/.rvm/gems/ruby-3.2.1/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:34:in `block (2 levels) in cleaning'
     # /home/joao/.rvm/gems/ruby-3.2.1/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:35:in `cleaning'
     # ./spec/rails_helper.rb:129:in `block (2 levels) in <top (required)>'

  3) Student features edit page should be able to edit record
     Failure/Error: expect(page).to have_css("td.name-column", text: "teste")
       expected to find css "td.name-column" but there were no matches
     # ./spec/features/students_spec.rb:150:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:130:in `block (3 levels) in <top (required)>'
     # /home/joao/.rvm/gems/ruby-3.2.1/gems/database_cleaner-core-2.0.1/lib/database_cleaner/strategy.rb:30:in `cleaning'
     # /home/joao/.rvm/gems/ruby-3.2.1/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:34:in `block (2 levels) in cleaning'
     # /home/joao/.rvm/gems/ruby-3.2.1/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:35:in `cleaning'
     # ./spec/rails_helper.rb:129:in `block (2 levels) in <top (required)>'

Finished in 8 minutes 2 seconds (files took 7.59 seconds to load)
1295 examples, 3 failures

Failed examples:

rspec ./spec/features/professors_spec.rb:130 # Professors features edit page should be able to edit record
rspec ./spec/features/students_spec.rb:107 # Student features insert page should have city widget for birth_city
rspec ./spec/features/students_spec.rb:144 # Student features edit page should be able to edit record

Randomized with seed 33671

Edit: a propósito, a sugestão de mensagem de commit é sem deixar a parte "if applied, this commit will" explícita. No caso, ficaria só "fix errors in the test and bypass the node_modules directory for git"

[codeclimate[bot]]

Code Climate has analyzed commit c51b064a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 67.7%.

View more on Code Climate.

[JoaoFelipe]

Aparentemente foi problema no meu ambiente: os testes passaram no CI

[IgorMonardez]

Provavelmente, no meu ambiente todos rodaram Igor Monárdez

Estudante de Ciência da Computação UFF

Em sex., 17 de mai. de 2024 às 17:06, João Felipe N. Pimentel < @.***> escreveu:

Aparentemente foi problema no meu ambiente: os testes passaram no CI

— Reply to this email directly, view it on GitHub https://github.com/gems-uff/sapos/pull/462#issuecomment-2118309843, or unsubscribe https://github.com/notifications/unsubscribe-auth/AU3E3ETTBKDD5WXE3CALAWTZCZPLRAVCNFSM6AAAAABH234RGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGMYDSOBUGM . You are receiving this because you authored the thread.Message ID: @.***>