search

gemstation / gemforge

Command-line tool for building, deploying and upgrading Diamond Standard contracts on EVM chains.
https://gemforge.xyz
MIT License
17 stars 4 forks source link

Make all methods external in IDiamondProxy interface #44

Closed amarinkovic closed 2 months ago

amarinkovic commented 2 months ago

In case when gemforge is configured to include public methods from the facets (config.diamond.publicMethods), for generating the IDiamondProxy, public methods are included as such. This brakes the compilation, since solidity requires all the methods in an interface to be external.

If configured to do so, gemforge should pickup the public methods, but expose them as external in the interface.

hiddentao commented 2 months ago

See #46

hiddentao commented 2 months ago

Fixed in 2.9.1