The "Remove" action - Githubissues

hiddentao commented 1 year ago

This is commented out in the code because at the moment it would remove the the essential ones from the Diamond library due to how the upgrade logic works.

We could just exclude these when doing a removal - but since removal is such a destructive action I am thinking it should be something you still have to specifically enable via a CLI option.

The proposal:

Removals must be enabled in the config file with the diamond.upgrades.removals = true value
All core facets (DiamondLoupe, DiamondCut, Ownership) will be excluded from removals
Remaining removals will be done
Gemforge will output a warning stating that removals will take place.
Enable a hard-reset on a certain facet, i.e. remove all non-essential functions

hiddentao commented 1 year ago

Removals are now working. Added a new config option to specify "core" facets that should never be removed: https://gemforge.xyz/configuration/diamond/

hiddentao commented 1 year ago

Splitting hard reset into new ticket -> #15

gemstation / gemforge

The "Remove" action #8