Closed jeroenvermeulen closed 3 years ago
There are some compiler warnings, I have to say I am not a C++ expert so it would take me a lot of research to understand and solve these:
lib/lib_display/Arduino_ST7789-gemu-1.0/Arduino_ST7789.cpp: In member function 'void Arduino_ST7789::init(uint16_t, uint16_t)':
lib/lib_display/Arduino_ST7789-gemu-1.0/Arduino_ST7789.cpp:556:21: warning: narrowing conversion of '((((int)((Arduino_ST7789*)this)->Arduino_ST7789::<anonymous>.Renderer::<anonymous>.Adafruit_GFX::_width) + ((int)((Arduino_ST7789*)this)->Arduino_ST7789::_xstart)) >> 8)' from 'int' to 'uint8_t {aka unsigned char}' inside { } [-Wnarrowing]
(_width+_xstart) >> 8,
^
lib/lib_display/Arduino_ST7789-gemu-1.0/Arduino_ST7789.cpp:557:21: warning: narrowing conversion of '((((int)((Arduino_ST7789*)this)->Arduino_ST7789::<anonymous>.Renderer::<anonymous>.Adafruit_GFX::_width) + ((int)((Arduino_ST7789*)this)->Arduino_ST7789::_xstart)) & 255)' from 'int' to 'uint8_t {aka unsigned char}' inside { } [-Wnarrowing]
(_width+_xstart) & 0xFF, // XEND = 240
^
lib/lib_display/Arduino_ST7789-gemu-1.0/Arduino_ST7789.cpp:560:25: warning: narrowing conversion of '((((int)((Arduino_ST7789*)this)->Arduino_ST7789::<anonymous>.Renderer::<anonymous>.Adafruit_GFX::_height) + ((int)((Arduino_ST7789*)this)->Arduino_ST7789::_ystart)) >> 8)' from 'int' to 'uint8_t {aka unsigned char}' inside { } [-Wnarrowing]
(_height+_ystart) >> 8,
^
lib/lib_display/Arduino_ST7789-gemu-1.0/Arduino_ST7789.cpp:561:22: warning: narrowing conversion of '((((int)((Arduino_ST7789*)this)->Arduino_ST7789::<anonymous>.Renderer::<anonymous>.Adafruit_GFX::_height) + ((int)((Arduino_ST7789*)this)->Arduino_ST7789::_xstart)) & 255)' from 'int' to 'uint8_t {aka unsigned char}' inside { } [-Wnarrowing]
(_height+_xstart) & 0xFF, // YEND = 240
^
Cleaned up code, defines instead of overrides.
Description:
Related issue (if applicable): fixes #28
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass