Code formatter - Githubissues

gen-smtp / gen_smtp

The extensible Erlang SMTP client and server library.

Other

683 stars 266 forks source link

Closed seriyps closed 2 years ago

seriyps commented 2 years ago

Just a proof of concept to start the discussion.

Pros:

Cons:

git blame will be confusing by default (unless one does git config --global blame.ignoreRevsFile .git-blame-ignore-revs, which is quite common solution)
- already opened PRs and forks would get quite big merge conflicts (could be solved by running rebar3 fmt over the fork's source tree). But right now we don't have that many open PRs.

mworrell commented 2 years ago

For me this is easier to read, so I'm for the change.

mworrell commented 2 years ago

Maybe it is good to rebase and merge #235 before we merge this.

Other PRs don't seem ready to merge.

seriyps commented 2 years ago

I'll rebase

mworrell commented 2 years ago

Looks good to me!

@arjan are you ok?

mworrell commented 2 years ago

@seriyps Go ahead and merge.

Then we can ask @Maria-12648430 to check her pull request https://github.com/gen-smtp/gen_smtp/pull/307

seriyps commented 2 years ago

Thanks! 🎉

Maria-12648430 commented 2 years ago

Then we can ask @Maria-12648430 to check her pull request #307

Heeey! Don't make me your guinea pig 😅 j/k

There are some merge conflicts, as expected. I'll have to look at them more closely later, busy right now 😉

mworrell commented 2 years ago

Sorry 😇

cw789 commented 2 years ago

Glad this got merged. Thanks.