gen-smtp / gen_smtp

The extensible Erlang SMTP client and server library.
Other
683 stars 266 forks source link

new version please 🙏 #312

Closed dustinfarris closed 2 years ago

dustinfarris commented 2 years ago

need the dropped hut dependency — can peg to the latest commit but would prefer a new release if it makes sense. thanks!

cw789 commented 2 years ago

I also think this would be necessary with the release of Elixir v1.14 as it seems rebar2 support is dropped in Mix. Anyway I don't know why hut is build with rebar2 within Mix.

arjan commented 2 years ago

@mworrell @seriyps I can release a new version tomorrow, wdyt? A lot has been changed, last release was over a year ago.. not sure if there are any backward incompatibilities though.

mworrell commented 2 years ago

@arjan I am for a release! A lot has been done.

arjan commented 2 years ago

Okay waiting for @seriyps for feedback on #311 otherwise i'll release without it end of the day

ak-14 commented 2 years ago

@arjan any update on this?

cw789 commented 2 years ago

Let us not rush. Elixir v1.13.4 do just warn of the deprecation of rebar2. The hard deprecation will follow in v1.14, which is still some week away (in my opinion).

So to all us Elixir users. I think everything should still work. It's just a red warning. 😶‍🌫️

arjan commented 2 years ago

I've tagged 1.2.0 now and published to hex!

arjan commented 2 years ago

Docs also built and published now, and github release page updated.

cw789 commented 2 years ago

Thanks a lot for your work.

cw789 commented 2 years ago

One thing I've found. ExDoc source_ref seems to expect a tag like v1.2.0. So either tag it as that or we need to manually set the source_ref in the rebar.config.

But this just means the source links within the docs do not work.

arjan commented 2 years ago

Hmm interesting.. where do you see this issue?

cw789 commented 2 years ago

image

arjan commented 2 years ago

Okay so I traced the issue, the problem is that the rebar3_ex_doc plugin makes this assumption, here

arjan commented 2 years ago

was already reported actually https://github.com/starbelly/rebar3_ex_doc/issues/18