search

gen2brain / beeep

Go cross-platform library for sending desktop notifications, alerts and beeps
BSD 2-Clause "Simplified" License
1.43k stars 89 forks source link

Fix Javascript build, removing gopherjs in favour of syscall/js #45

Closed prologic closed 2 years ago

gen2brain commented 2 years ago

Thanks, I saw that gopherjs is archived, just didn't find the time to do it. Why remove go.sum though? Also, can interface{} be used instead of any? Don't want to force the version of Go to the latest if there is no need.

prologic commented 2 years ago

Thanks, I saw that gopherjs is archived, just didn't find the time to do it. Why remove go.sum though? Also, can interface{} be used instead of any? Don't want to force the version of Go to the latest if there is no need.

Not sure why go.sum was removed, I'll fix 👌

As for Go 1.18 -- I'll try and see if my project still builds.

prologic commented 2 years ago

Yup still builds okay 👌

=> https://git.mills.io/saltyim/saltyim/pulls/108

prologic commented 2 years ago

@gen2brain Note that I haven't actually removed go.sum at all, this is just the result of running go mod tidy.

gen2brain commented 2 years ago

Ah, ok, good. What about any, can you replace it with the interface{}?

prologic commented 2 years ago

Ah, ok, good. What about any, can you replace it with the interface{}?

Ahh yes sorry I forgot 😅

prologic commented 2 years ago

Done

gen2brain commented 2 years ago

Merged, thanks!