feature request: tolerate junk _MACOSX and .DS_Store sub-directories in zip archives.

gen2brain / cbconvert

CBconvert is a Comic Book converter

GNU General Public License v3.0

215 stars 13 forks source link

feature request: tolerate junk _MACOSX and .DS_Store sub-directories in zip archives. #37

Closed rwperrott closed 2 weeks ago

rwperrott commented 4 months ago

A sane approach would be to exclude processing or copying of _MACOSX and .DS_Store sub-directories. It's annoying having to separately manually delete this junk, so that this tool can process these archives.

gen2brain commented 4 months ago

There is already option --no-nonimage or Remove Non-Image Files from the Archive, but it probably needs some review.

rwperrott commented 4 months ago

The snag is that I want to retain any other non image files, like comic meta data files, whereas those Apple MacOS directories are always junk, in my opinion. Fortunately I only see them rarely.

gen2brain commented 2 weeks ago

Sorry, if you can just reiterate, the issue is with the existing archives and junk in them, or is the issue when creating new archives (I don't think so, but let's check)? I guess the proposal is to just nuke and ignore whenever.

gen2brain commented 2 weeks ago

Addressed in https://github.com/gen2brain/cbconvert/commit/f85fe990ff57b7061c3f513af72862c4448a91b9. Now it will always just skip such files. The new release has been uploaded.