search

genandnic / Wall-Jump

https://www.curseforge.com/minecraft/mc-mods/wall-jump
14 stars 23 forks source link

Enchantment config option doesn't properly disable enchantments #25

Open Boingboingsplat opened 3 years ago

Boingboingsplat commented 3 years ago

Even if you set enableEnchantments = false in walljump-common.toml, it's still possible to find enchanted books with the enchants, and to apply the enchant to books in the enchanting table. I've yet to confirm if you can get them by directly enchanting items instead of books.

Kisutora commented 3 years ago

Can confirm. Books can still get the enchantments. image image

Kisutora commented 3 years ago

Also appears in villager trades! Options to disable only certain enchantments would be very welcome as well! image

DocArgon commented 3 years ago

I looked at the code. That "disabling" config doesn't do almost anything. The mod registers those enchants no matter what is set there. I frankensteined an edit that actually disables them for good. Beware that you can't enable them in my version. walljump-forge-1.16.4-1.3.7-mod.jar.zip

AzureMonument commented 2 years ago

@DocArgon don't suppose you can make a frankenstein for 1.18 of that? Cause it certainly doesn't seem this will be fixed any time soon....

DocArgon commented 2 years ago

@AzureMonument I guess I can try. Although I haven't really tested this. walljump-forge-1.18.1-1.3.7_noEnchants.jar.zip