search

genba-games / morsemadness

Transmission team ADKL
https://berith.itch.io/m-m
GNU General Public License v3.0
5 stars 1 forks source link

Deal with the mysterious chin #29

Closed berithpy closed 6 years ago

berithpy commented 6 years ago

For some reason the maze generator dies when you shrink the canvas. I'm looking into it and it dies when the maze generator is setting the corner down right to the wall. Another thing i realized is that it does not happen if you set the y offset to 0. The first question that comes to my mind is why do we deal with offsets instead of absolutes? I'm still looking into it using this issue as a log!

berithpy commented 6 years ago

Nevermind my question, the offset acts like x and y coordinates!

AlejoAsd commented 6 years ago

The bottom and top edges are quite the hacks. I would not be surprised if the bottom row is writing out of the array bounds.

On Feb 20, 2018 5:29 PM, "Diego Díaz" notifications@github.com wrote:

For some reason the maze generator dies when you shrink the canvas. I'm looking into it and it dies when the maze generator is setting the corner down right to the wall. Another thing i realized is that it does not happen if you set the y offset to 0. The first question that comes to my mind is why do we deal with offsets instead of absolutes? I'm still looking into it using this issue as a log!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/genba-games/morsemadness/issues/29, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdhI3BquHrqhy4HcO1OKBCxgJYdNRLfks5tWykngaJpZM4SMmuw .

berithpy commented 6 years ago

The chin has been dealt with in the 6292193 commit.