Closed berithpy closed 6 years ago
This pr deal with both #30 and #31
After starting and stopping, the signals can't knock the morse arrows for some reason, will look into it and then work on some data analyzing.
When you kill the morse pattern without being killed by the operators signals, the arrows don't get proper names so you can't kill them after restarting.
It was the singalQ not resetting!
It needs some better presentation of the data to the player and i'd say this feature is done.
I'll deal with #39 on this repo too.
I think that the UI needs a lot of work but i'ts a good representation of what we can do with the profiler.
@AlejoAsd I'd say this task is done, i'd like a review or at least a skim, i'll merge it anyways tomorrow by 19pm, we can fix any problems with it afterwards!
Give me a little more time I'd like to give it a look. Wed 7pm tops sound good?
On Mon, Mar 26, 2018, 12:08 AM Diego Díaz notifications@github.com wrote:
@AlejoAsd https://github.com/AlejoAsd I'd say this task is done, i'd like a review or at least a skim, i'll merge it anyways tomorrow by 19pm, we can fix any problems with it afterwards!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/genba-games/morsemadness/pull/38#issuecomment-376041021, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdhI_JDLoI1XCCqil2D1XPIrLS5zK6Mks5tiGnTgaJpZM4SSJ0i .
I wanted to have it done to show it at Tuesdays meet up, at least somewhere where people could access it, it's ok if you can't, there are monthly meetings now!
On Mon, Mar 26, 2018, 12:15 AM Alejo Carballude notifications@github.com wrote:
Give me a little more time I'd like to give it a look. Wed 7pm tops sound good?
On Mon, Mar 26, 2018, 12:08 AM Diego Díaz notifications@github.com wrote:
@AlejoAsd https://github.com/AlejoAsd I'd say this task is done, i'd like a review or at least a skim, i'll merge it anyways tomorrow by 19pm, we can fix any problems with it afterwards!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/genba-games/morsemadness/pull/38#issuecomment-376041021 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAdhI_JDLoI1XCCqil2D1XPIrLS5zK6Mks5tiGnTgaJpZM4SSJ0i
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/genba-games/morsemadness/pull/38#issuecomment-376041795, or mute the thread https://github.com/notifications/unsubscribe-auth/AH7oMQzGvvg6HMzisTjv88gOK1kZTvcTks5tiGttgaJpZM4SSJ0i .
Oh, OK. I'll have it done tomorrow, but sometime before 9pm.
On Mon, Mar 26, 2018, 12:19 AM Diego Díaz notifications@github.com wrote:
I wanted to have it done to show it at Tuesdays meet up, at least somewhere where people could access it, it's ok if you can't, there are monthly meetings now!
On Mon, Mar 26, 2018, 12:15 AM Alejo Carballude notifications@github.com wrote:
Give me a little more time I'd like to give it a look. Wed 7pm tops sound good?
On Mon, Mar 26, 2018, 12:08 AM Diego Díaz notifications@github.com wrote:
@AlejoAsd https://github.com/AlejoAsd I'd say this task is done, i'd like a review or at least a skim, i'll merge it anyways tomorrow by 19pm, we can fix any problems with it afterwards!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <
https://github.com/genba-games/morsemadness/pull/38#issuecomment-376041021
, or mute the thread <
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/genba-games/morsemadness/pull/38#issuecomment-376041795 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AH7oMQzGvvg6HMzisTjv88gOK1kZTvcTks5tiGttgaJpZM4SSJ0i
.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/genba-games/morsemadness/pull/38#issuecomment-376042254, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdhI0BOWUTfjgiQYYELCwgpD5UWNR23ks5tiGxngaJpZM4SSJ0i .
This PR adds the "Training" game mode where there is only one player that takes the role of the operator, it adds GAME ANALYTICS and some more fixes to the main game. The end goal for this pr was originally to have some way to produce data to define pattern difficulty, there is a lot of room for improvements on the training mode(like adding a time limit, choosing the generated patterns difficulty etc) but for now its a good proof of concept. It also added a .env file and some improvements to the travis file.