genboy / Festival

Custom events plugin for Pocketmine
https://genboy.net/minecraft/festival/
Other
38 stars 15 forks source link

Error when Level Management is selected #253

Closed AL3XPI closed 4 years ago

AL3XPI commented 4 years ago

@genboy Whenever I click level management after doing /fe menu, it disconnects me and leaves this error in the logs:

2019-12-16 [09:59:47] [Server thread/CRITICAL]: TypeError: "Argument 3 passed to xenialdan\customui\CustomForm::addDropdown() must be of the type int or null, bool given, called in phar:///home/ac/Vareon/plugins/Festival.phar/src/genboy/Festival/FormUI.php on line 962" (EXCEPTION) in "plugins/Festival.phar/src/xenialdan/customui/CustomForm" at line 110
2019-12-16 [09:59:47] [Server thread/DEBUG]: #0 plugins/Festival.phar/src/genboy/Festival/FormUI(962): xenialdan\customui\CustomForm->addDropdown(string[12] Level select, array[2], boolean , string[13] selectedLevel)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #1 plugins/Festival.phar/src/genboy/Festival/FormUI(72): genboy\Festival\FormUI->levelForm(object pocketmine\Player)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #2 plugins/Festival.phar/src/xenialdan/customui/Form(48): genboy\Festival\FormUI->genboy\Festival\{closure}(object pocketmine\Player, integer 3)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #3 src/pocketmine/Player(3494): xenialdan\customui\Form->handleResponse(object pocketmine\Player, integer 3)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #4 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(265): pocketmine\Player->onFormSubmit(integer 0, integer 3)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #5 src/pocketmine/network/mcpe/protocol/ModalFormResponsePacket(49): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleModalFormResponse(object pocketmine\network\mcpe\protocol\ModalFormResponsePacket)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(111): pocketmine\network\mcpe\protocol\ModalFormResponsePacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/protocol/BatchPacket(123): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\ModalFormResponsePacket)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(111): pocketmine\network\mcpe\protocol\BatchPacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #9 src/pocketmine/Player(3158): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/RakLibInterface(169): pocketmine\Player->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #11 vendor/pocketmine/raklib/src/server/ServerHandler(99): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string[17] 192.168.1.1 56183, object raklib\protocol\EncapsulatedPacket, integer 0)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/RakLibInterface(109): raklib\server\ServerHandler->handlePacket()
2019-12-16 [09:59:47] [Server thread/DEBUG]: #13 src/pocketmine/network/mcpe/RakLibInterface(99): pocketmine\network\mcpe\RakLibInterface->process()
2019-12-16 [09:59:47] [Server thread/DEBUG]: #14 vendor/pocketmine/snooze/src/SleeperHandler(123): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
2019-12-16 [09:59:47] [Server thread/DEBUG]: #15 vendor/pocketmine/snooze/src/SleeperHandler(85): pocketmine\snooze\SleeperHandler->processNotifications()
2019-12-16 [09:59:47] [Server thread/DEBUG]: #16 src/pocketmine/Server(2346): pocketmine\snooze\SleeperHandler->sleepUntil(double 1576508387.4826)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #17 src/pocketmine/Server(2203): pocketmine\Server->tickProcessor()
2019-12-16 [09:59:47] [Server thread/DEBUG]: #18 src/pocketmine/Server(1785): pocketmine\Server->start()
2019-12-16 [09:59:47] [Server thread/DEBUG]: #19 src/pocketmine/PocketMine(272): pocketmine\Server->__construct(object BaseClassLoader, object pocketmine\utils\MainLogger, string[16] /home/ac/Vareon/, string[24] /home/ac/Vareon/plugins/)
2019-12-16 [09:59:47] [Server thread/DEBUG]: #20 src/pocketmine/PocketMine(295): pocketmine\server()
2019-12-16 [09:59:47] [Server thread/DEBUG]: #21 (1): require(string[71] phar:///home/ac/Vareon/PocketMine-MP.phar/src/pocketmine/PocketMine.php)

I have tried reinstalling Festival, deleting the old plugin_files folder for Festival, to no avail, as I continue to get this error. I am using the latest version of Festival and Pocketmine. Please help.

genboy commented 4 years ago

@AL3XPI thank you for the report, i'll try to fix this asap and let you know when dev version is available.

genboy commented 4 years ago

@AL3XPI i could not reproduce the exact error but found almost the same problem; while ingame creating a new level and then going to Festival level management threw an error. Here's an dev update for testing, including a new feature to tab positions in midair (holding the magic item or in command mode /pos1, rad etc.)

AL3XPI commented 4 years ago

When I use your dev phar and click level management I get this error:

2019-12-21 [08:54:54] [Server thread/CRITICAL]: TypeError: "Argument 3 passed to xenialdan\customui\CustomForm::addDropdown() must be of the type int or null, bool given, called in phar:///[redacted]/plugins/Festival.phar/src/genboy/Festival/FormUI.php on line 977" (EXCEPTION) in "plugins/Festival.phar/src/xenialdan/customui/CustomForm" at line 110
2019-12-21 [08:54:54] [Server thread/DEBUG]: #0 plugins/Festival.phar/src/genboy/Festival/FormUI(977): xenialdan\customui\CustomForm->addDropdown(string[12] Level select, array[3], boolean , string[13] selectedLevel)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #1 plugins/Festival.phar/src/genboy/Festival/FormUI(75): genboy\Festival\FormUI->levelForm(object sys\arenapvp\ArenaPlayer)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #2 plugins/Festival.phar/src/xenialdan/customui/Form(48): genboy\Festival\FormUI->genboy\Festival\{closure}(object sys\arenapvp\ArenaPlayer, integer 3)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #3 src/pocketmine/Player(3494): xenialdan\customui\Form->handleResponse(object sys\arenapvp\ArenaPlayer, integer 3)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #4 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(265): pocketmine\Player->onFormSubmit(integer 0, integer 3)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #5 src/pocketmine/network/mcpe/protocol/ModalFormResponsePacket(49): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleModalFormResponse(object pocketmine\network\mcpe\protocol\ModalFormResponsePacket)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(111): pocketmine\network\mcpe\protocol\ModalFormResponsePacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/protocol/BatchPacket(123): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\ModalFormResponsePacket)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(111): pocketmine\network\mcpe\protocol\BatchPacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #9 src/pocketmine/Player(3158): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/RakLibInterface(169): pocketmine\Player->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #11 vendor/pocketmine/raklib/src/server/ServerHandler(99): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string[17] 192.168.1.1 61224, object raklib\protocol\EncapsulatedPacket, integer 0)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/RakLibInterface(109): raklib\server\ServerHandler->handlePacket()
2019-12-21 [08:54:54] [Server thread/DEBUG]: #13 src/pocketmine/network/mcpe/RakLibInterface(99): pocketmine\network\mcpe\RakLibInterface->process()
2019-12-21 [08:54:54] [Server thread/DEBUG]: #14 vendor/pocketmine/snooze/src/SleeperHandler(123): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
2019-12-21 [08:54:54] [Server thread/DEBUG]: #15 vendor/pocketmine/snooze/src/SleeperHandler(85): pocketmine\snooze\SleeperHandler->processNotifications()
2019-12-21 [08:54:54] [Server thread/DEBUG]: #16 src/pocketmine/Server(2346): pocketmine\snooze\SleeperHandler->sleepUntil(double 1576936494.9528)
2019-12-21 [08:54:54] [Server thread/DEBUG]: #17 src/pocketmine/Server(2203): pocketmine\Server->tickProcessor()
2019-12-21 [08:54:54] [Server thread/DEBUG]: #18 src/pocketmine/Server(1785): pocketmine\Server->start()
2019-12-21 [08:54:54] [Server thread/DEBUG]: #19 src/pocketmine/PocketMine(272): pocketmine\Server->__construct(object BaseClassLoader, object pocketmine\utils\MainLogger, string[16] [redacted])
2019-12-21 [08:54:54] [Server thread/DEBUG]: #20 src/pocketmine/PocketMine(295): pocketmine\server()
2019-12-21 [08:54:54] [Server thread/DEBUG]: #21 (1): require(string[71] phar://[redacted]/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
AL3XPI commented 4 years ago

@genboy I figured it out, it's an error with one of my plugins, thank you for the help though. 👍 Keep being the wonderful dev you are! 😊

genboy commented 4 years ago

@AL3XPI Good to hear! If you can let me know which plugin so I can double check for future compatibility. Thank you!